Skip to content

make helper function return error #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2020
Merged

make helper function return error #3553

merged 2 commits into from
Apr 23, 2020

Conversation

zouyee
Copy link
Contributor

@zouyee zouyee commented Apr 21, 2020

Signed-off-by: zounengren [email protected]

zounengren added 2 commits April 21, 2020 10:03
make helper function return error
b858c98 
Signed-off-by: zounengren <[email protected]>
remove empty line
58f8950 
Signed-off-by: Zou Nengren <[email protected]>
easwars
easwars approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !!

@easwars easwars merged commit 29f40a4 into grpc:master Apr 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zouyee @easwars