Webserver bug #416
Merged
Webserver bug #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
- this flag prevented the dismissal of keyboard after an attempt to edit any EditTextPreference was made. We want the keyboard to dismiss after any edit for better UX Signed-off-by: Arka Prava Basu <[email protected]>
- my work email got commited due to automatic signature from my work machine. Replace that with my personal email Signed-off-by: Arka Prava Basu <[email protected]>
- less memory per instance + no implicit ref to parent class Signed-off-by: Arka Prava Basu <[email protected]>
- helps in logging and better equality checks Signed-off-by: Arka Prava Basu <[email protected]>
- add assertion to prevent Nullable warnings in lint Signed-off-by: Arka Prava Basu <[email protected]>
- string representation of Date object is not allowed causing an IllegalStateException which prevented display of EventTriggers - fixes issue guardianproject#410 Signed-off-by: Arka Prava Basu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #410
Please review and consider merging