Skip to content

added fade in for tourtips #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2015
Merged

Conversation

britztopher
Copy link
Collaborator

Added the fade in css for tour tips

@britztopher
Copy link
Collaborator Author

@gustvao is doing this just in css what we are looking for? If not, I think we can add css rules right in the directive.

@gustvao
Copy link
Owner

gustvao commented Oct 17, 2014

hey @britztopher ,

I couldnt run grunt serve on it, it is breaking, can you pls fix it?

Running "autoprefixer:dist" (autoprefixer) task
Warning: Can't parse CSS: missing '}' near line 17:3 Use --force to continue.

@britztopher
Copy link
Collaborator Author

@gustvao Im not getting any errors on my branch. Did you merge my code in? If so did you do a grunt build to replace the css in the build folder. grunt serve works for me.

Running "autoprefixer:dist" (autoprefixer) task
Prefixed file ".tmp/styles/tour/tour.css" created.

Done, without errors.

@britztopher
Copy link
Collaborator Author

@gustvao still having issues with PR?

@gustvao
Copy link
Owner

gustvao commented Oct 21, 2014

hey @britztopher , yes.

this is what I receive after running grunt build

screenshot-guga guga-hp-pavilion-dv2700 -angular-angular-tour

@gustvao
Copy link
Owner

gustvao commented Oct 27, 2014

hey @britztopher any luck with this?

@britztopher
Copy link
Collaborator Author

@gustvao Yeah im trying to get the error to reproduce, but I am getting clean build. Ill try getting this done by tomorrow

@britztopher
Copy link
Collaborator Author

@gustvao i upgraded some things and will be using this in my project now. I would accept this pr then we can talk about future of this project (if there is one) I really like this little library, so lets see if we can hurdle this minor speed bump

gustvao added a commit that referenced this pull request Sep 16, 2015
@gustvao gustvao merged commit e8198ba into gustvao:master Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants