Skip to content

Clarify discrepancies in Oscillart instructions #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jams/batches/oscillart/part-1/en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,12 @@ Now, at the bottom right of your screen, you should see a button in your toolbar

## Athena Awards and Hackatime

If you are doing this project for the **Athena Awards**, you have to set up **Hackatime** on your Codespaces environment, so that you can earn artifacts for each hour you spend coding. Luckily, Codespaces is identical to Visual Studio Code, so I will link [the instructions for installing Hackatime for VSCode](https://hackatime.hackclub.com/docs/editors/vs-code) and you should be able to follow those exactly.
If you are doing this project for the **Athena Awards**, you have to set up **Hackatime** on your Codespaces environment, so that you can earn artifacts for each hour you spend coding. Luckily, Codespaces is identical to Visual Studio Code, so I will link [the instructions for installing Hackatime for VSCode](https://hackatime.hackclub.com/docs/editors/vs-code) and you should be able to follow those exactly. (To set up Hackatime for Codespaces, **follow the instructions for Mac/Linux**, even if you're using a Windows device!)

Note - because Codespaces is online, after you install Hackatime and the Wakatime extension, you may have to wait a few minutes, and then refresh the Codespaces browser. When you see a clock in the bottom left corner of your toolbar, like this:

![Hackatime-ready toolbar in VSCode](https://hc-cdn.hel1.your-objectstorage.com/s/v3/717164df1373f666887ed3faefb3df68b29f73a2_screenshot_2025-06-06_at_11.48.28___am.png)

Even if the clock says 0 minutes or “start coding to get started”, then you have successfully installed Hackatime!

<br />
<br />
4 changes: 2 additions & 2 deletions jams/batches/oscillart/part-4/en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Add the following code *after your first for-loop* in your handle() function. Fo
}


}, 1000)
}, 2000)
```

Some methods you should take away from this:
Expand Down Expand Up @@ -251,4 +251,4 @@ There we go! We’ve sized out our sine waves so they’ll always fit within our

### Advanced Challenge: becuase of the way our setInterval function works, the user has to wait the length of timepernote until the first wave is drawn... is there a way we could change the code to fix this? <br/><br/> I'm leaving you to play with that on your own right now, but ask around on the #oscillart channel for help if you take it on!

<br />
<br />
4 changes: 2 additions & 2 deletions jams/batches/oscillart/part-5/en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ Answer:
gainNode.gain.setValueAtTime(vol_slider.value, audioCtx.currentTime);
setting = setInterval(() => {gainNode.gain.value = vol_slider.value}, 1);
oscillator.frequency.setValueAtTime(pitch, audioCtx.currentTime);
setTimeout(() => { clearInterval(setting); gainNode.gain.value = 0; }, ((timepernote)-10));
setTimeout(() => { clearInterval(setting); gainNode.gain.value = 0; }, ((timepernote)-100));
```
</Dropdown>

Expand Down Expand Up @@ -230,4 +230,4 @@ One cool way to do this? Add a new user input! Here’s a list of things you cou
- Add MULTIPLE streams of audio coming out!!
- Make it 3D! - inspired by @Space_Duck

<br />
<br />