-
Notifications
You must be signed in to change notification settings - Fork 217
Homepage redesign #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Manan-Coder
wants to merge
56
commits into
hackclub:main
Choose a base branch
from
Manan-Coder:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Homepage redesign #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file for its cards.
…m for better navigation.
…d fixed some scaling problems
…ed kinda dead so i gave a description about "happenings", im seeing happenings as something bigger than a newsletter for just hackclubbers, I want it to be publicly accessible, like a thing by which parents can be upto date with the things going in hackclub as they cant access slack, secondly there are few people who wanna be a part of hackclub but cant join because they are adult or any other reason, so this way they can see whats "happening" in hackclub, so yeah it can kind of yk be a public showcase thingy of hackclub. Idk how good of an idea this is but yeah it sounds good to me, i'd love to hear suggestions if someone is reading this :)
…w cursor events as such
…hrefs to /ship. My thinking behind adding a project carousel is imagine if a teenager will come to our website they'll see that we give coffee/boba/minecraft projects, thats cool but after one point they dont excite you that much. But if they'll see children of their age making things like a 3d printer from scratch, running games in a pdf then they'll be like "yo this shi is dope, people are making real good things in it, maybe i should check out more", thats the whole thought process behind adding this, i want to add like bg image to it but i think i should focus on other things cuz i got very little time left, i'll probably made a new pr or just update this one if i make it in time
fixed the ladder doodle component, it will disappear on small screens like mobile and be responsive on big monitors, laptop screens, tablets
so the last thing worked, earlier the build was showing / , /arcade/shop and /arcade in the error, now it only shows / (home page) , so this should fix that issue too (i hope it does)
an image was having .JPG as filetype so it wasnt being rendered on vercel coz of linux being case sensitive (not sure if its like that for filetypes but i should test it once). Also i found a problem in hc site, the thing is that it crashes when we open inspect elements, i use chrome so prob it will be like that on any other chromium based browser, i think its big problem and caused due to hc site being heavy, i will try to look at it but probably its coz of the ancient files this repo has accumulated over a decade.
alr so i made some huge changes in the hero section, ealier it was using assemble's group image as the main photo and bg was a lined paper image i stole from scrapyard's website, but the photo from outernet is such a vibe, i asked a few people which of the designs is looking better and they said that the photo is really good, so i put the outernet photo as the main center photo, widened it, and put the assemble photo as the bg rather than the lined paper with a black tint/shade. So rn its looking quite good.
added image loading screen, optimised their rendering and added fallbacks in case of issues
The background assemble image was a whopping 24mb, which made the site load really slowly, i compressed it to 2.5mb
so the last thing worked really fine, but the rendering suddenly lagged in between then i realised that one another assemble image is around 9mb and it was being used as a small image in the side so i compressed it heavily to 250kb
…first to increase performance
…ms on mid sized screens like 13-15 inch laptops
…maller laptops like macbook (13 inch)
removed onboard and added journey to the carousel, made the color scheme of the project carousel cards with the color scheme of the project (for now i did it manually but if this thing is continued then i'll probably make a form a to submit to put the project in carousel and add a "color pallete" box in it as optional modification)
migrated it to the landing component
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Manan-Coder is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Wow, this is awesome! I specifically love the landing. It looks so great. I shared a couple pieces of feedback on the review call - overall great work! This qualifies for $50 USD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
things i did -
it is built on vercel at -
https://hackclub-site.vercel.app/