Fix shared library loading without dev packages on Linux #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, happy to merge this but, is it neccessary to build all of openresty to run the tests? Could we just use a pre-built openresty image instead? Just seems like something fairly complicated to maintain and potentially fragile |
|
Ah yes you are right, I can just use docker. Let me try that. |
3 tasks
|
Thank you @hamishforbes , would you release a new version to include this fix? |
|
Yep, had to re-acquaint myself with opm/luarocks as it's been a while! Released as 0.6 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds tests thorugh GHA.