Skip to content

Commit c082525

Browse files
savardcarb
authored andcommitted
Rename serverTimeout to serverUnavailable. Closes #117. (#119)
* Rename serverTiemout to serverUnavailable * Revert TOC changes * Put back tests for serverTimeout
1 parent 5d67ac0 commit c082525

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -653,14 +653,14 @@ Generates the following response payload:
653653
}
654654
```
655655

656-
### `Boom.serverTimeout([message], [data])`
656+
### `Boom.serverUnavailable([message], [data])`
657657

658658
Returns a 503 Service Unavailable error where:
659659
- `message` - optional message.
660660
- `data` - optional additional error data.
661661

662662
```js
663-
Boom.serverTimeout('unavailable');
663+
Boom.serverUnavailable('unavailable');
664664
```
665665

666666
Generates the following response payload:

lib/index.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,11 +375,14 @@ exports.badGateway = function (message, data) {
375375
};
376376

377377

378-
exports.serverTimeout = function (message, data) {
378+
exports.serverUnavailable = function (message, data) {
379379

380-
return internals.serverError(message, data, 503, exports.serverTimeout);
380+
return internals.serverError(message, data, 503, exports.serverUnavailable);
381381
};
382382

383+
// Deprecated
384+
exports.serverTimeout = exports.serverUnavailable;
385+
383386

384387
exports.gatewayTimeout = function (message, data) {
385388

test/index.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,6 @@ describe('illegal()', () => {
526526
});
527527
});
528528

529-
530529
describe('serverTimeout()', () => {
531530

532531
it('returns a 503 error statusCode', (done) => {
@@ -542,6 +541,21 @@ describe('serverTimeout()', () => {
542541
});
543542
});
544543

544+
describe('serverUnavailable()', () => {
545+
546+
it('returns a 503 error statusCode', (done) => {
547+
548+
expect(Boom.serverUnavailable().output.statusCode).to.equal(503);
549+
done();
550+
});
551+
552+
it('sets the message with the passed in message', (done) => {
553+
554+
expect(Boom.serverUnavailable('my message').message).to.equal('my message');
555+
done();
556+
});
557+
});
558+
545559
describe('forbidden()', () => {
546560

547561
it('returns a 403 error statusCode', (done) => {
@@ -678,8 +692,8 @@ describe('stack trace', () => {
678692
'badData', 'preconditionRequired', 'tooManyRequests',
679693

680694
// 500s
681-
'internal', 'notImplemented', 'badGateway', 'serverTimeout', 'gatewayTimeout',
682-
'badImplementation'
695+
'internal', 'notImplemented', 'badGateway', 'serverTimeout', 'serverUnavailable',
696+
'gatewayTimeout', 'badImplementation'
683697
].forEach((name) => {
684698

685699
const err = Boom[name]();

0 commit comments

Comments
 (0)