Skip to content

Rename serverTimeout to serverUnavailable #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2016
Merged

Rename serverTimeout to serverUnavailable #119

merged 3 commits into from
Jun 20, 2016

Conversation

savardc
Copy link
Contributor

@savardc savardc commented Jun 16, 2016

Modifications for #117

arb
arb reviewed Jun 16, 2016
View reviewed changes
README.md
@@ -40,7 +40,7 @@ Lead Maintainer: [Adam Bretz](https://github.com/arb)
- [`Boom.badImplementation([message], [data])`](#boombadimplementationmessage-data)
- [`Boom.notImplemented([message], [data])`](#boomnotimplementedmessage-data)
- [`Boom.badGateway([message], [data])`](#boombadgatewaymessage-data)
- [`Boom.serverTimeout([message], [data])`](#boomservertimeoutmessage-data)
- [`Boom.serverUnavailable([message], [data])`](#boomserverunavailablemessage-data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the changes to the table of contents; it is automatically generated.

@arb arb self-assigned this Jun 16, 2016
@arb
Copy link
Contributor

arb commented Jun 16, 2016 •
edited
Loading

You'll need to keep serverTimeout. I don't want to do a breaking change. Just add serverUnavailable as an alias to serverTimeout and update the documentation to talk about serverUnavailable

@savardc
Copy link
Contributor Author

savardc commented Jun 16, 2016

I kept it, line 384

On Thu, Jun 16, 2016 at 4:22 PM Adam Bretz [email protected] wrote:

You'll need to keep serverTimeout. I don't to do a breaking change. Just
add serverUnavailable as an alias to serverTimeout and update the
documentation to talk about serverUnavailable

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#119 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA096oeXDpGeUjv8DysJqM9lVojnZFHeks5qMbCFgaJpZM4I3pGR
.

@arb
Copy link
Contributor

arb commented Jun 17, 2016

Can you also keep the test in so we can be absolutely sure it doesn't break. We'll remove it all in a subsequent release.

@arb arb changed the title Rename serverTiemout to serverUnavailable Rename serverTimeout to serverUnavailable Jun 17, 2016
@arb arb added this to the 3.2.2 milestone Jun 20, 2016
@arb arb merged commit c082525 into hapijs:master Jun 20, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@arb arb

Labels
None yet
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@savardc @arb