Enable deployment of mock backend via netlify functions. #29
Conversation
levino
force-pushed
the
feature/deployment
branch
2 times, most recently
from
54d8458 to
1330d0d
Compare
levino
force-pushed
the
feature/deployment
branch
from
1330d0d to
5777d1f
Compare
levino
force-pushed
the
feature/deployment
branch
9 times, most recently
from
aa0854f to
d075850
Compare
levino
force-pushed
the
feature/deployment
branch
from
d075850 to
5e1cb8f
Compare
levino
force-pushed
the
feature/deployment
branch
from
5295945 to
15335f0
Compare
| ]; | ||
|
|
||
| for (var i = 55600; i < 85600; i++) { | ||
| for (let i = 55600; i < 58600; i++) { |
There was a problem hiding this comment.
The let instead of var comes from prettier on file save. let is of course correct here as i is going to be heavily mutated. I also changed the number of returned entities here because the lambda functions refuse to return more than 6mb of data and I see no need for this heavy load test anyhow.
| @@ -481,4 +495,16 @@ module.exports = function (app, port) { | |||
| }, LONG_DELAY); | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| const createApi = () => { | |||
There was a problem hiding this comment.
Nice factory function that returns a ready to start express app for us.
| @@ -20,7 +22,6 @@ | |||
| "storybook": "start-storybook -p 9009 -s public", | |||
| "build-storybook": "build-storybook -s public" | |||
| }, | |||
| "homepage": "/app/static", | |||
There was a problem hiding this comment.
Hardcoding this here is a mistake. We would have to annoyingly overwrite this for every staging deployment. The default value always works fine. For the actual deployment (I guess the app finally is shipped by the Java backend) we would need to set the equivalent environment variable PUBLIC_URL.
No description provided.