Bump shell-3.0.2; fix resourceNames signature (DO NOT MERGE) #219
+35
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <[email protected]>
torchiaf
force-pushed
the
resource-names-signature
branch
from
78aef20 to
8100ce6
Compare
a110605
reviewed
Mar 26, 2025
package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "node": ">=20.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "@rancher/shell": "3.0.2-rc.6", | |||
| "@rancher/shell": "3.0.2", | |||
There was a problem hiding this comment.
Change to shell 3.0.4 once it's out ?
Shell 3.0.2 still has
resourceNames(names, t, options = {})
There was a problem hiding this comment.
Yes, please help me to put the correct shell version.
There was a problem hiding this comment.
Sure, once incomatible PR merged and new shell release, I will update the version.
Signed-off-by: Andy Lee <[email protected]>
a110605
changed the title
a110605
changed the title
|
Won't merge until we need to support Rancher 2.10 from harvester 1.5.0. |
a110605
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Checklists
Related Issue
Test screenshot/video
Extra technical notes summary