Skip to content

fix: import paths that are missing /index #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

aklkv
Copy link
Collaborator

@aklkv aklkv commented Apr 19, 2025

πŸ“Œ Summary

πŸ› οΈ Detailed description

πŸ“Έ Screenshots

πŸ”— External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Apr 19, 2025
@aklkv aklkv requested a review from a team as a code owner April 19, 2025 07:48
Copy link

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Apr 19, 2025 7:52am
hds-website βœ… Ready (Inspect) Visit Preview Apr 19, 2025 7:52am

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things, before approving:

  • can you add a meaningful description to the PR? (for future reference, to give context to the reviewer, etc)
  • can you move the code changes to the tests to a different PR? so the two changes are kept separated (I am not sure how this related to this PR; I suspect this should have been done time ago when we postponed the Enterprise Navigation release; which btw is likely coming back soon :) )

@aklkv
Copy link
Collaborator Author

aklkv commented Apr 23, 2025

I will put it on hold, SFC work might supersede this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants