🧪 [Spike] Viewport breakpoints (re-using IBM Carbon values/mixins) #2844
+695
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashibot-hds
added
packages/components
docs-website
didoo
force-pushed
the
spike-viewport-breakpoints
branch
from
71780e4 to
2f31758
Compare
hashibot-hds
removed
packages/components
docs-website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 DO NOT MERGE 🚨
📌 Summary
This PR is an exploration of how we could potentially use the IBM Carbon breakpoints values and mixins within HDS (eg. for our components) and expose them to our consumers.
👉 👉 👉 Preview: https://hds-showcase-git-spike-viewport-breakpoints-hashicorp.vercel.app/foundations/breakpoints
🚧 TODOs
showcase/app/styles/_temp-hds-breakpoints.scss) under thepackages/componentsfolder.showcase/app/components/mock/demo/hds-breakpoints.ts)🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-4806