Modal
: fix issue with click outside to dismiss
#2846
+54
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged this PR would update Modal to not use
ember-focus-trap
to dismiss the Modal on click outside and instead use our own click event.It also fixes an issue where the scroll bar would get added back if try to close the modal when
isDismissDisabled=true
.🛠️ Detailed description
This is necessary because the
ember-focus-trap
'sclickOutSideDeactivates
only ever runs once. If a consumer conditionally disables the ability to dismiss the modal, the user may not be able to click outside to deactivate it.Steps to reproduce:
🔗 External links
Jira ticket: HDS-3972
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.