Static IP, IPv6 and MAC addresses with Podman >=4.0.0 #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
f-support-static-ip
branch
from
0cc7b18 to
a3b99c1
Compare
Resolve #293 and #358 adding ipv6_address, ipv4_address, static_ips and static_mac options for podman tasks. Podman API version checks whether to set the properties directly or whether to use the new PerNetworkOptions framework. ipv6_address and ipv4_address are provided for backwards compatibility, and for compatibility with docker. For Podman 4.0.0 these are merged into static_ips and sent as a PerNetorkOptions entry for the default network. Added API version check, static mac support, new array-based option for static IPs to match the podman API Fixes: #293 Fixes: #358
tgross
force-pushed
the
f-support-static-ip
branch
from
a3b99c1 to
10e0a2b
Compare
tgross
force-pushed
the
f-support-static-ip
branch
from
10e0a2b to
6bbb6c7
Compare
|
Evening, thanks for getting this PR through. I haven't looked properly at the comments on my PR but not being overly familiar with go definitely appreciate the work done to get this feature over the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses rebases #359 and addresses review comments. We'd left the PR open for quite some time and don't want to make the original author come back to fix it now, and permissions on the author's fork don't allow me to push to it. I've retained the original commit and authorship of @zandeez, of course. Original PR description below:
Resolve #293 and #358 adding ipv6_address, ipv4_address, static_ips and static_mac options for podman tasks.
Podman API version checks whether to set the properties directly or whether to use the new PerNetworkOptions framework.
ipv6_address and ipv4_address are provided for backwards compatibility, and for compatibility with docker. For Podman 4.0.0 these are merged into static_ips and sent as a PerNetorkOptions entry for the default network. Added API version
check, static mac support, new array-based option for static IPs to match the podman API
Fixes: #293
Fixes: #358