This repository was archived by the owner on May 6, 2020. It is now read-only.
Fix a condition #145
Merged
Fix a condition #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behaviour didn't cause issues, because setting a working dir of "" is equivalent to setting ".". But better to fix this behaviour.
sudomateo
suggested changes
Feb 25, 2020
| @@ -33,7 +33,7 @@ function parseInputs { | |||
|
|
|||
| # Optional inputs | |||
| tfWorkingDir="." | |||
| if [ "${INPUT_TF_ACTIONS_WORKING_DIR}" != "" ] || [ "${INPUT_TF_ACTIONS_WORKING_DIR}" != "." ]; then | |||
| if [[ -n "${INPUT_TF_ACTIONS_WORKING_DIR}" ]]; then | |||
There was a problem hiding this comment.
Suggested change
| if [[ -n "${INPUT_TF_ACTIONS_WORKING_DIR}" ]]; then | |
| if [ -n "${INPUT_TF_ACTIONS_WORKING_DIR}" ]; then |
|
I'm concerned about that change because it's a little less safe if you ever
decide to run this script with 'set -u' (which I think is a good idea!)
…On Tue, 25 Feb 2020, 5:34 pm Matthew Sanabria, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/main.sh
<#145 (comment)>
:
> @@ -33,7 +33,7 @@ function parseInputs {
# Optional inputs
tfWorkingDir="."
- if [ "${INPUT_TF_ACTIONS_WORKING_DIR}" != "" ] || [ "${INPUT_TF_ACTIONS_WORKING_DIR}" != "." ]; then
+ if [[ -n "${INPUT_TF_ACTIONS_WORKING_DIR}" ]]; then
⬇️ Suggested change
- if [[ -n "${INPUT_TF_ACTIONS_WORKING_DIR}" ]]; then
+ if [ -n "${INPUT_TF_ACTIONS_WORKING_DIR}" ]; then
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#145?email_source=notifications&email_token=AAC4U5KBOSNZGV6MTL3CNO3RES3W3A5CNFSM4K24QGKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWYKILY#pullrequestreview-363897903>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4U5I2IC2MUJUDBIQCUS3RES3W3ANCNFSM4K24QGKA>
.
|
|
@alexjurkiewicz I'm not sure I agree with that statement. Especially since the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behaviour didn't cause issues, because setting a working dir of
"" is equivalent to setting ".". But better to fix this behaviour.