Skip to content

enable appengineflex service to fix app engine flex version tests #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3286.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ func TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample(t *te
t.Parallel()

context := map[string]interface{}{
"org_id": getTestOrgFromEnv(t),
"random_suffix": acctest.RandString(10),
}

Expand All @@ -52,6 +51,12 @@ func TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample(t *te

func testAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample(context map[string]interface{}) string {
return Nprintf(`
resource "google_project_service" "service" {
service = "appengineflex.googleapis.com"

disable_dependent_services = false
}

resource "google_app_engine_flexible_app_version" "myapp_v1" {
version_id = "v1"
service = "tf-test-service-%{random_suffix}"
Expand Down
13 changes: 12 additions & 1 deletion google-beta/resource_app_engine_flexible_app_version_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,16 @@ func TestAccAppEngineFlexibleAppVersion_update(t *testing.T) {
},
},
})

}

func testAccAppEngineFlexibleAppVersion_python(resourceName string) string {
return fmt.Sprintf(`
resource "google_project_service" "project" {
service = "appengineflex.googleapis.com"

disable_dependent_services = false
}

resource "google_app_engine_flexible_app_version" "foo" {
version_id = "v1"
service = "%s"
Expand Down Expand Up @@ -127,6 +132,12 @@ resource "google_storage_bucket_object" "main" {

func testAccAppEngineFlexibleAppVersion_pythonUpdate(resourceName string) string {
return fmt.Sprintf(`
resource "google_project_service" "project" {
service = "appengineflex.googleapis.com"

disable_dependent_services = false
}

resource "google_app_engine_flexible_app_version" "foo" {
version_id = "v1"
service = "%s"
Expand Down
9 changes: 9 additions & 0 deletions website/docs/r/app_engine_flexible_app_version.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ the App Engine flexible environment automatically scales your app up and down wh
Learn about the differences between the standard environment and the flexible environment
at https://cloud.google.com/appengine/docs/the-appengine-environments.

~> **Note:** The App Engine flexible environment service account uses the member ID `service-[YOUR_PROJECT_NUMBER]@gae-api-prod.google.com.iam.gserviceaccount.com`
It should have the App Engine Flexible Environment Service Agent role, which will be applied when the `appengineflex.googleapis.com` service is enabled.


To get more information about FlexibleAppVersion, see:

Expand All @@ -43,6 +46,12 @@ To get more information about FlexibleAppVersion, see:


```hcl
resource "google_project_service" "service" {
service = "appengineflex.googleapis.com"

disable_dependent_services = false
}

resource "google_app_engine_flexible_app_version" "myapp_v1" {
version_id = "v1"
service = "service-"
Expand Down