Skip to content

Remove default_from_api from certificateId field #7936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Remove default_from_api=true property from certificateId field in ManagedSslCertificate resource

The field is marked as default_from_api=true and output=true at the same time. default_from_api property takes precedence and hence the field is marked as Optional + Computed which is not correct as the field shouldn't be optional.

This issue has a small impact in TF behavior because it will probably allow customers to modify the field, but the impact should be minor as probably the API will reject modifying an output only field + I don't believe customers will modify it anyways.

Also according to #15585, setting default_from_api=true made config connector position the field in spec section (which should contain only modifiable fields), though I see that the field currently is placed properly.

Anyways, as long as this is a breaking change, we would prefer to fix it now to avoid any future hassle.

Fixes: hashicorp/terraform-provider-google#15585
b/312432901

Release Note Template for Downstream PRs (will be copied)

compute: stopped the `certifcate_id` field in `google_compute_managed_ssl_certificate` resource being incorrectly marked as a user-configurable value when it should just be an output.

Derived from GoogleCloudPlatform/magic-modules#11409

Co-authored-by: Hamza Hassan <[email protected]>

[upstream:974c2f97ec389518f88ec036e8512ed51f1b8967]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a1d20b1 into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Aug 9, 2024
3 checks passed
@modular-magician modular-magician deleted the downstream-pr-974c2f97ec389518f88ec036e8512ed51f1b8967 branch November 16, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant