Remove default_from_api from certificateId field #7936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
default_from_api=true
property fromcertificateId
field inManagedSslCertificate
resourceThe field is marked as
default_from_api=true
andoutput=true
at the same time. default_from_api property takes precedence and hence the field is marked asOptional
+Computed
which is not correct as the field shouldn't be optional.This issue has a small impact in TF behavior because it will probably allow customers to modify the field, but the impact should be minor as probably the API will reject modifying an output only field + I don't believe customers will modify it anyways.
Also according to #15585, setting
default_from_api=true
made config connector position the field inspec
section (which should contain only modifiable fields), though I see that the field currently is placed properly.Anyways, as long as this is a breaking change, we would prefer to fix it now to avoid any future hassle.
Fixes: hashicorp/terraform-provider-google#15585
b/312432901
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11409