feat: Remove force replacement from gcfs_config #8101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:b3e10c032f80f42f5a53aab2f8c151cfcb465627] Signed-off-by: Modular Magician <[email protected]>
shuyama1
pushed a commit
that referenced
this pull request
Sep 20, 2024
[upstream:b3e10c032f80f42f5a53aab2f8c151cfcb465627] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-b3e10c032f80f42f5a53aab2f8c151cfcb465627
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gcfsconfig changes do not require to re-create node pools hence there is no point to ForceNew on each gcfsconfig change, gcfs can be enabled and disabled via GUI or gcloud CLI without recreating node pools, examples:
https://cloud.google.com/kubernetes-engine/docs/how-to/image-streaming#disable
https://cloud.google.com/kubernetes-engine/docs/how-to/image-streaming#enable_on_node_pools
Also, same issue noted here hashicorp/terraform-provider-google#18417
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11553