feat(monitoring_alert_policy): support notification prompts #8457
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#8470
This PR adds support for setting notification prompts in the alert strategy for
google_monitoring_alert_policy
resource. This allows users to specify when notifications should be sent for an alert policy. For example, users can choose to send notifications only when an alert is fired, or when it is both fired and recovered. This feature was recently introduced in the Google Cloud Monitoring API and is not yet supported by the Terraform provider. See REST API doc.OPENED
andCLOSED
are set by default.CLOSED
.NOTIFICATION_PROMPT_UNSPECIFIED
will result in an error.When only
CLOSED
is specified:The following error is returned, so the user can identify the issue from the error message provided by the API. IMO, validation on the Terraform side isn't necessary.
When
NOTIFICATION_PROMPT_UNSPECIFIED
is specified:The following error is returned. The API documentation also states "Treated as error", so I'm not sure if it makes sense to allow this to be specified in Terraform.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#12052