Network peering routes config updates #9320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:f47a75e9f7c3ca3fdec451e8355938982e5f3ee5] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the import_subnet_routes_with_public_ip and export_subnet_routes_with_public_ip fields to the compute resource google_compute_network_peering_routes_config.
Fixes: hashicorp/terraform-provider-google#11573
Although there is an API side default, I set these fields as required without defaults as people may have this resource already in state, and it is undesirable to change without explicitly choosing to.
This mirrors the approach of import_custom_routes and export_custom_routes. Please let me know if there is a better approach.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12581