Skip to content

Deprecate google_notebooks_location since it is not an actual resource #9373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Deprecate google_notebooks_location since it is not an actual resource #9373

merged 1 commit into from
Feb 20, 2025

Conversation

modular-magician
Copy link
Collaborator

This was added in GoogleCloudPlatform/magic-modules#3620

I believe it was meant to only be used for ResourceRefs of the other resources, and not to be an actual resource itself. I was not able to find working create/delete endpoints, the resource is not used in any tests, and there are no issues referencing it. I also tried to provision the resource locally, and received a 404:

google_notebooks_location.loc: Creating...
╷
│ Error: Error creating Location: googleapi: got HTTP response code 404 with body: <!DOCTYPE html>
│ <html lang=en>
│   <meta charset=utf-8>
│   <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
│   <title>Error 404 (Not Found)!!1</title>
│   <style>
│     *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
│   </style>
│   <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
│   <p><b>404.</b> <ins>That’s an error.</ins>
│   <p>The requested URL <code>/v1/projects/ryanoaksnightly2/locations?alt=json</code> was not found on this server.  <ins>That’s all we know.</ins>

Release Note Template for Downstream PRs (will be copied)

notebooks: deprecated non-functional `google_notebooks_location` resource

Derived from GoogleCloudPlatform/magic-modules#11972

@modular-magician
Deprecate google_notebooks_location since it is not an actual resourc…
3b6213b 
…e (#11972)

[upstream:b6ee7d1cafebb70e6a63c9f00b138e0f34b858f7]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 20, 2025 17:49
@modular-magician modular-magician merged commit 67bbfc4 into hashicorp:main Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician