Increase range of CloudSQL Query Insights string length & plans per minute to match Enterprise Plus limits #9539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inute to match Enterprise Plus limits (#13299) [upstream:c17cc7712139fff3a068535276b0b649ffb7c61a] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After following the docs to increase the CloudSQL Query Insights string length and plan per minute limits we found that the Terraform provider's validation function hasn't been increased to match the new-ish Enterprise Plus limits. This PR modifies the validation function to account for the Enterprise Plus limits.
I see in the Google docs that this is marked as a preview feature. I'm not sure if that means these increased limits should be a beta-only change, or if it's okay to have it in both. I also wonder if changing the validation function based on the edition of the instance is a better idea?
Anyways, let me know what you think and I'm happy to update this PR to match
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#13299