Skip to content

spanner: Properly set fieldMask when removing autoscaling #9542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Before this fix disabling autoscaling would fail with the following error:

googleapi: Error 400: The user should include both autoscaling_config and node_count/processing_units in the field masks, and explicitly clear the autoscaling_config field when disabling autoscaling.

Fixes hashicorp/terraform-provider-google#21652

Added two acceptance tests to surface this issue.

  • TestAccSpannerInstance_basicWithAutoscalingUsingPrecessingUnitsConfigUpdateDisableAutoscaling
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdateDisableAutoscaling
spanner: fixed issue with disabling autoscaling in `google_spanner_instance`

Derived from GoogleCloudPlatform/magic-modules#13263

[upstream:d5d3f0ba605e652a22b87914b0a521dc0cef6ae3]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 13, 2025 02:20
@modular-magician modular-magician merged commit 497f561 into hashicorp:main Mar 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_spanner_instance no possibility to disable autoscaler
1 participant