Skip to content

Support for importing google_logging_organization_sink and google_logging_folder_sink #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcin-kolda opened this issue May 15, 2018 · 1 comment
Closed

Support for importing google_logging_organization_sink and google_logging_folder_sink #1494

marcin-kolda opened this issue May 15, 2018 · 1 comment
Assignees
@rileykarson
Labels
enhancement

Comments

@marcin-kolda
Copy link
Contributor

marcin-kolda commented May 15, 2018 •
edited
Loading

Please add support for importing google_logging_organization_sink and google_logging_folder_sink resources.

Currently I'm getting error:

terraform import google_logging_organization_sink.org_logs_sink_resource_type_api resource_type-api
google_logging_organization_sink.org_logs_sink_resource_type_api: Importing from ID "resource_type-api"...

Error: google_logging_organization_sink.org_logs_sink_resource_type_api (import id: resource_type-api): import google_logging_organization_sink.org_logs_sink_resource_type_api (id: resource_type-api): resource google_logging_organization_sink doesn't support import

I get the similar error during importing google_logging_folder_sink.

Used versions:

Terraform v0.11.7
+ provider.google v1.12.0
@marcin-kolda marcin-kolda changed the title Support for importing google_logging_organization_sink Support for importing google_logging_organization_sink and google_logging_folder_sink May 15, 2018
@rileykarson rileykarson mentioned this issue Aug 10, 2018
Merged
@chrisst chrisst assigned chrisst and rileykarson and unassigned chrisst Sep 4, 2018
rileykarson added a commit that referenced this issue Sep 6, 2018
@rileykarson
Add import support for org, folder, billing logging sinks (#1860)
035a581 
Fixes #1494.

* Add import support for `google_logging_organization_sink`, `google_logging_folder_sink`, `google_logging_billing_account_sink`.

Using `StateFunc` over `DiffSuppressFunc` should only affect tests; for some reason `TestAccLoggingFolderSink_folderAcceptsFullFolderPath` expected a `folder` value of `folders/{{id}}` vs expecting `{{id}}` when only `DiffSuppressFunc` was used, when in real use `DiffSuppressFunc` should be sufficient.
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this issue Nov 9, 2018
@rileykarson
Add import support for org, folder, billing logging sinks (hashicorp#…
99bfa1b 
…1860)

Fixes hashicorp#1494.

* Add import support for `google_logging_organization_sink`, `google_logging_folder_sink`, `google_logging_billing_account_sink`.

Using `StateFunc` over `DiffSuppressFunc` should only affect tests; for some reason `TestAccLoggingFolderSink_folderAcceptsFullFolderPath` expected a `folder` value of `folders/{{id}}` vs expecting `{{id}}` when only `DiffSuppressFunc` was used, when in real use `DiffSuppressFunc` should be sufficient.
@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rileykarson rileykarson

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marcin-kolda @chrisst @rileykarson @emilymye