Skip to content

Add Support for Optional Log Fields to google_cloud_region_backend_service #19187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments

@mhottinger1
Copy link

mhottinger1 commented Aug 20, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

The log_config field for google_compute_region_backend_service currently only supports two functions:

  1. Enabling logs
  2. Adjusting the sample rate

There are two additional options that can be set, but not currently supported by this provider plug-in.

Optional Logging - lets you specify the optional fields you want to log. Supported options:

  • INCLUDE_ALL_OPTIONAL
  • EXCLUDE_ALL_OPTIONAL
  • CUSTOM

At a minimum support for INCLUDE_ALL_OPTIONAL will satisfy the need. Further documentation for these options can be found here:
https://cloud.google.com/load-balancing/docs/l7-internal/monitoring

New or Affected Resource(s)

  • google_compute_region_backend_service

Potential Terraform Configuration

resource “google_compute_region_backend_service” “my_compute_region_backend” { 
  …
  log_config: {
    enable = true
    sample_rate = 1
    log_optional = true
}

References

No response

b/362277896

@melinath
Copy link
Collaborator

Note from triage: This is requesting support for the logConfig.optionalMode field. https://cloud.google.com/compute/docs/reference/rest/v1/regionBackendServices

Ideally we'd also add this field to google_compute_backend_service to keep them in sync.

@melinath melinath added size/s and removed forward/review In review; remove label to forward labels Aug 26, 2024
@melinath melinath added this to the Goals milestone Aug 26, 2024
@njay4928
Copy link

Is this available? @melinath @mhottinger1

@mhottinger1
Copy link
Author

@njay4928 The maintainers of the project have not yet merged the enhancement into mainline.

Copy link

github-actions bot commented Apr 5, 2025

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.