Add Optional Log Fields to google_cloud_region_backend_service

[Dawid212]

This PR adds optional log fields to to google_cloud_region_backend_service

Related Issues

• Resolves: Add Support for Optional Log Fields to google_cloud_region_backend_service hashicorp/terraform-provider-google#19187

Release Note

See Write release notes for guidance.

compute: added `log_config.optional_mode` and `log_config.optional_fields` fields to `google_compute_region_backend_service` resource  

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

Code LGTM, just need to make sure tests pass

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 243 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 243 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

[modular-magician]

Tests analytics

Total tests: 588
Passed tests: 522
Skipped tests: 62
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionBackendService_ilbUpdateFull
• TestAccComputeRegionBackendService_withLogConfig
• TestAccComputeRegionTargetHttpsProxy_addServerTlsPolicy_withForwardingRule
• TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_ilbUpdateFull [Error message] [Debug log]
TestAccComputeRegionBackendService_withLogConfig [Error message] [Debug log]
TestAccComputeRegionTargetHttpsProxy_addServerTlsPolicy_withForwardingRule [Error message] [Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[roaks3]

Note that only TestAccComputeRegionBackendService_withLogConfig looks relevant to this PR. It seems the update to include optional fields is failing in some way.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 153 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 153 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_backend_service (161 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  log_config {
    optional_fields = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1121
Passed tests: 1040
Skipped tests: 77
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionBackendService_ilbUpdateFull
• TestAccComputeRegionBackendService_withLogConfig
• TestAccComputeRegionTargetHttpsProxy_addServerTlsPolicy_withForwardingRule
• TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_withLogConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_ilbUpdateFull [Error message] [Debug log]
TestAccComputeRegionTargetHttpsProxy_addServerTlsPolicy_withForwardingRule [Error message] [Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

Sorry, while the test I highlighted in my last comment is now fixed, the other tests do appear to be a result of this change. I verified by checking our nightly tests, which show these tests passing consistently.

It looks like there is server-side default behavior that you'll need to work out to make sure that Terraform stays happy (I'm guessing optionalMode needs default_from_api: true, and optionalFields might too)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 155 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 155 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_backend_service (162 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  log_config {
    optional_fields = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1133
Passed tests: 1048
Skipped tests: 79
Affected tests: 6

Click here to see the affected service packages

• compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceFromMachineImage_terminationTime
• TestAccComputeInstanceFromTemplate_TerminationTime
• TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime
• TestAccComputeInstance_schedulingTerminationTime
• TestAccComputeRegionBackendService_withLogConfig
• TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceFromMachineImage_terminationTime [Debug log]
TestAccComputeInstanceFromTemplate_TerminationTime [Debug log]
TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccComputeInstance_schedulingTerminationTime [Debug log]
TestAccComputeRegionBackendService_withLogConfig [Debug log]
TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test