Skip to content

Update vendor/google.golang.org/api/sqladmin/v1beta4/ #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ubschmidt2 opened this issue Nov 9, 2017 · 4 comments
Closed

Update vendor/google.golang.org/api/sqladmin/v1beta4/ #711

ubschmidt2 opened this issue Nov 9, 2017 · 4 comments

Comments

@ubschmidt2
Copy link
Contributor

After googleapis/google-api-go-client#201 and googleapis/google-api-go-client@95e5582#diff-0403962fa047edf278ce76f09c1d6dd6, the vendored version of sqladmin diverges from the current version (in a breaking way).

It would be nice to update the vendored version to the current version, especially for users who don't like multiple versions of the same thing in their codebase. @danawillow

@ubschmidt2
Copy link
Contributor Author

FWIW, googleapis/google-api-go-client#201 (comment) indicates that other APIs are affected, too. However, it seems to me that it's not blocking anything as ForceSendFields has already been added in a couple of places (#208, hashicorp/terraform#14582).

@danawillow
Copy link
Contributor

What do you mean by "multiple versions of the same thing in their codebase"? There's currently one vendored version, and when it's updated there will still be just one vendored version.

Regardless, this will be indirectly fixed in #695 :)

@ubschmidt2
Copy link
Contributor Author

Thanks! Great, #695 fixes this. Let's close this #711 then.

luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants