Add diff suppress for empty network policy provider in GKE cluster #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
reviewed
Jan 31, 2018
google/resource_container_cluster.go
Outdated
| @@ -310,6 +310,7 @@ func resourceContainerCluster() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| DiffSuppressFunc: emptyOrDefaultStringSuppress("PROVIDER_UNSPECIFIED"), | |||
There was a problem hiding this comment.
I believe the DiffSuppressFunc should be on the provider field under network_policy. Could you test quickly with a simple config that it works and reports to the PR about your test. Thanks :)
There was a problem hiding this comment.
I don't know how it worked before - anyways, done! I added some test steps to the network policy test as well.
emilymye
force-pushed
the
container_network_policy_1031
branch
from
da465a9 to
10ef26a
Compare
rosbo
approved these changes
Feb 1, 2018
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031
make test TEST=./google TESTARGS='-run=TestEmptyOrDefaultStringSuppress'
==> Checking that code complies with gofmt requirements...
go test -i ./google || exit 1
echo ./google |
xargs -t -n4 go test -run=TestEmptyOrDefaultStringSuppress -timeout=30s -parallel=4
go test -run=TestEmptyOrDefaultStringSuppress -timeout=30s -parallel=4 ./google
ok github.com/terraform-providers/terraform-provider-google/google 0.170s