Extra error handling for things that don't match the regex. #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running affected tests now. |
danawillow
approved these changes
Mar 3, 2018
| @@ -368,6 +368,9 @@ func flattenNodePool(d *schema.ResourceData, config *Config, np *container.NodeP | |||
| for _, url := range np.InstanceGroupUrls { | |||
| // retrieve instance group manager (InstanceGroupUrls are actually URLs for InstanceGroupManagers) | |||
| matches := instanceGroupManagerURL.FindStringSubmatch(url) | |||
| if len(matches) < 4 { | |||
| return nil, fmt.Errorf("Error reading instance group manage URL '%s'", url) | |||
There was a problem hiding this comment.
nit: '%s' is equivalent to %q
|
All container tests passed. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1136 - there was an issue with the URL returned and an IndexOutOfBounds panic from this function - seems like it can really only be this issue.