Add project to container cluster import name. #1282
Conversation
| { | ||
| Config: testAccContainerCluster_basic(clusterName), | ||
| }, | ||
| { |
There was a problem hiding this comment.
Let's actually add this as an additional step to the existing _basic test instead, just to save a bit of time
|
Ran test locally: $ make testacc TEST=./google TESTARGS='-run="TestAccContainerCluster_basic"' |
emilymye
force-pushed
the
container_cluster_import_1270
branch
from
a616125 to
8174bde
Compare
## What As well as #1282 , make `resource_container_node_pool` importer accept `{project}/{zone}/{cluster}/{name}` format to specify the project where the node pool belongs to actually. ## Why Sometimes I want to import container pool in different project from default SA's. However, currently there is no way to specify project the target node pool belongs to, Terraform tries to retrieve node pool from SA's project, then it fails due to `You cannot import non-existent resources using Terraform import.` error.
) ## What As well as hashicorp/terraform-provider-google#1282 , make `resource_container_node_pool` importer accept `{project}/{zone}/{cluster}/{name}` format to specify the project where the node pool belongs to actually. ## Why Sometimes I want to import container pool in different project from default SA's. However, currently there is no way to specify project the target node pool belongs to, Terraform tries to retrieve node pool from SA's project, then it fails due to `You cannot import non-existent resources using Terraform import.` error.
* allow import of container cluster by project as well * update docs for importing container cluster with project * combine tests
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #1270
Keeps old format for backwards compat