Skip to content

Add support for shielded instance config on auto provisioned GKE nodes #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

part of #9180

Just now when I opening this PR I found out that this PR exists GoogleCloudPlatform/magic-modules#6636 which is larger but does include what we need (being able to turn on secure boot). If you'd rather get that PR through feel free to close this, otherwise this PR offers a smaller chunk of those changes.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added support for Shielded Instance configuration for node auto-provisioning to `google_container_cluster`

Derived from GoogleCloudPlatform/magic-modules#6754

@modular-magician modular-magician merged commit f78d7a5 into hashicorp:main Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
@modular-magician modular-magician deleted the downstream-pr-93b1f8ad3c22a58b9bd1b9e0ac4ccf6c01d9a99b branch November 17, 2024 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant