Skip to content

Update tests for Composer 1 & 2 with node_config, also Update docs for Composer 2 #14315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Update docs for Composer 2. 

Add tests for network tags field for Composer 1 & 2.

Derived from GoogleCloudPlatform/magic-modules#7670

…r Composer 2 (hashicorp#7670)

* Update decumentation. Composer2 also has tags as optional parameter.

CHG: Realistic oauth_scopes.

* FIX: wrong function.

* FIX: Disk size 2-> 20.

* CHG: Name to reflect broather sense of tests.

* FIX: composer version 1->2 in proper test. Rm: Unused function.

* CHG: Names remove _withTags. RM: Zone, max_pods, use_ip_aliases from Composer2.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 2445ffe into hashicorp:main Apr 13, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
@modular-magician modular-magician deleted the downstream-pr-6f9e4bdc6c267769e41f6089706e0e7b25a94c82 branch November 17, 2024 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant