Skip to content

Added a new datasource for fetching the list of supported alloydb database flags in a location #14365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

This PR is for #13813

A new datasource google_alloydb_supported_database_flags for fetching the list of alloydb supported database flags in a location. It receives project and location as arguments and returns the details of each of the supported database flag in that location.

I have added documentation and tested this new data source with unit tests.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

note: this was reverted, marked as none

A new datasource for fetching the list of alloydb supported database flags in a location.

Derived from GoogleCloudPlatform/magic-modules#7679

…abase flags in a location (hashicorp#7679)

* Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types.

* Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT

* added new datasource for fetching all the alloydb supported database flags in a location.

* added new datasource for fetching all the alloydb supported database flags in a location.

* Using go client for api calls

* using v1 and v1beta go clients for GA and beta providers respectively

* Revert "added new datasource for fetching all the alloydb supported database flags in a location."

This reverts commit b5f728edb3b92adfc7a38d856b02f2f79f48b20d.

* making http calls using magic modules send request insted of alloydb go client

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 9a3bf31 into hashicorp:main Apr 20, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
@modular-magician modular-magician deleted the downstream-pr-fbf96754427bfbf55e365e9329640a25db060322 branch November 17, 2024 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant