Skip to content

chore: remove unused doc region tags #15149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

The samples linked in official documentation have been migrated to https://github.com/terraform-google-modules/terraform-docs-samples. These samples are automatically "copied" into other repos like GoogleCloudPlatform/k8s-config-connector, hashicorp/terraform-provider-google-beta, and hashicorp/terraform-provider-google. The copying of the region tags makes conflicts in DevRel services and inappropriately shows examples embedded in Go test code.

I have checked that there are no doc references to magic-modules, hashicorp/terraform-provider-google-beta, or hashicorp/terraform-provider-google

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

 remove unused doc region tags from serverless samples

Derived from GoogleCloudPlatform/magic-modules#8321

@modular-magician modular-magician merged commit 686653c into hashicorp:main Jul 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2023
@modular-magician modular-magician deleted the downstream-pr-5305765245f10a5b1ff51d59e655a835f1d4dc5c branch November 17, 2024 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant