Skip to content

Add new google_compute_regions #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions google/data_source_google_compute_regions.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package google

import (
"fmt"
"log"
"sort"
"time"

"github.com/hashicorp/terraform/helper/schema"
"github.com/hashicorp/terraform/helper/validation"
"google.golang.org/api/compute/v1"
)

func dataSourceGoogleComputeRegions() *schema.Resource {
return &schema.Resource{
Read: dataSourceGoogleComputeRegionsRead,
Schema: map[string]*schema.Schema{
"project": &schema.Schema{
Type: schema.TypeString,
Optional: true,
Computed: true,
},
"names": {
Type: schema.TypeList,
Computed: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
"status": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{"UP", "DOWN"}, false),
},
},
}
}

func dataSourceGoogleComputeRegionsRead(d *schema.ResourceData, meta interface{}) error {
config := meta.(*Config)

project, err := getProject(d, config)
if err != nil {
return err
}
filter := ""
if s, ok := d.GetOk("status"); ok {
filter = fmt.Sprintf(" (status eq %s)", s)
}

call := config.clientCompute.Regions.List(project).Filter(filter)

resp, err := call.Do()
if err != nil {
return err
}

regions := flattenRegions(resp.Items)
log.Printf("[DEBUG] Received Google Compute Regions: %q", regions)

d.Set("names", regions)
d.Set("project", project)
d.SetId(time.Now().UTC().String())

return nil
}

func flattenRegions(regions []*compute.Region) []string {
result := make([]string, len(regions), len(regions))
for i, region := range regions {
result[i] = region.Name
}
sort.Strings(result)
return result
}
72 changes: 72 additions & 0 deletions google/data_source_google_compute_regions_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package google

import (
"errors"
"fmt"
"strconv"
"testing"

"github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform"
)

func TestAccComputeRegions_basic(t *testing.T) {
t.Parallel()

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
Steps: []resource.TestStep{
{
Config: testAccCheckGoogleComputeRegionsConfig,
Check: resource.ComposeTestCheckFunc(
testAccCheckGoogleComputeRegionsMeta("data.google_compute_regions.available"),
),
},
},
})
}

func testAccCheckGoogleComputeRegionsMeta(n string) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[n]
if !ok {
return fmt.Errorf("Can't find regions data source: %s", n)
}

if rs.Primary.ID == "" {
return errors.New("regions data source ID not set.")
}

count, ok := rs.Primary.Attributes["names.#"]
if !ok {
return errors.New("can't find 'names' attribute")
}

noOfNames, err := strconv.Atoi(count)
if err != nil {
return errors.New("failed to read number of regions")
}
if noOfNames < 2 {
return fmt.Errorf("expected at least 2 regions, received %d, this is most likely a bug",
noOfNames)
}

for i := 0; i < noOfNames; i++ {
idx := "names." + strconv.Itoa(i)
v, ok := rs.Primary.Attributes[idx]
if !ok {
return fmt.Errorf("region list is corrupt (%q not found), this is definitely a bug", idx)
}
if len(v) < 1 {
return fmt.Errorf("Empty region name (%q), this is definitely a bug", idx)
}
}

return nil
}
}

var testAccCheckGoogleComputeRegionsConfig = `
data "google_compute_regions" "available" {}
`
1 change: 1 addition & 0 deletions google/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ func Provider() terraform.ResourceProvider {
"google_storage_object_signed_url": dataSourceGoogleSignedUrl(),
"google_storage_project_service_account": dataSourceGoogleStorageProjectServiceAccount(),
"google_compute_backend_service": dataSourceGoogleComputeBackendService(),
"google_compute_regions": dataSourceGoogleComputeRegions(),
},

ResourcesMap: mergeResourceMaps(
Expand Down
38 changes: 38 additions & 0 deletions website/docs/d/google_compute_regions.html.markdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
layout: "google"
page_title: "Google: google_compute_regions"
sidebar_current: "docs-google-datasource-compute-regions"
description: |-
Provides a list of available Google Compute regions
---

# google\_compute\_regions

Provides access to available Google Compute regions for a given project.
See more about [regions and regions](https://cloud.google.com/compute/docs/regions-zones/) in the upstream docs.

```
data "google_compute_regions" "available" {}

resource "google_compute_subnetwork" "cluster" {
count = "${length(data.google_compute_regions.available.names)}"
name = "my-network"
ip_cidr_range = "10.36.${count.index}.0/24"
network = "my-network"
region = "${data.google_compute_regions.available.names[count.index]}"
}
```

## Argument Reference

The following arguments are supported:

* `project` (Optional) - Project from which to list available regions. Defaults to project declared in the provider.
* `status` (Optional) - Allows to filter list of regions based on their current status. Status can be either `UP` or `DOWN`.
Defaults to no filtering (all available regions - both `UP` and `DOWN`).

## Attributes Reference

The following attribute is exported:

* `names` - A list of regions available in the given project
3 changes: 3 additions & 0 deletions website/google.erb
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
<li<%= sidebar_current("docs-google-datasource-project") %>>
<a href="/docs/providers/google/d/google_project.html">google_project</a>
</li>
<li<%= sidebar_current("docs-google-datasource-compute-regions") %>>
<a href="/docs/providers/google/d/google_compute_regions.html">google_compute_regions</a>
</li>
<li<%= sidebar_current("docs-google-datasource-compute-ssl-policy") %>>
<a href="/docs/providers/google/d/datasource_compute_ssl_policy.html">google_compute_ssl_policy</a>
</li>
Expand Down