[#16400] Fix and simplify InternalIpDiffSuppress function #16550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashicorp#9423) * [hashicorp#16400] Fix and simplify InternalIpDiffSuppress function * Fixes as per PR comments * Adding new tests for different netmasks * fix test * Fixes to unit tests * Fixes per comments * Comments fixes --------- Co-authored-by: Luca Prete <[email protected]> [upstream:06aa6a62bc9aed26c0c890c7bd41625ebca87173] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-06aa6a62bc9aed26c0c890c7bd41625ebca87173
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #16400 the PR
fixes the InternalIpDiffSuppress function, which currently generates a drift for net masked IPv6 addresses and non net-masked IPv6 addresses (i.e.
fd20:6c7:bb6a:f400:0:0:0:0/96-->fd20:6c7:bb6a:f400::)simplifies the InternalIpDiffSuppress function
Derived from GoogleCloudPlatform/magic-modules#9423