Terraform support for Workbench instances #16773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Workbench Instances * fix yaml to run tests * fix yaml to run tests * fix basic test * diff suppress for tags * add custom flattens * Add labels example * fix tags diff * custom_flatten with ignore_read * removed ignore_read * remove ignore_read on disks * Add kms key in full test * read_ignore for examples * clean up extra flattens * add update test * fix indent lint * fix wbi lint * fix lint issues * fix whitespace * change names in full test to vars * change tests to use variable names instead of hard coded values * stop wbi before updating machine_type * all tests passing * fix terraformgoogleconversion-codegen compiler error * make service account immutable * addressed issues with immutable fields * add disable_proxy_access into full example * Add disable_proxy_access in full test * remove returns in pre and post updates * test false values in secure vm config * fix empty shielded instance config * fixed update on non stop needing fields failing * create custom update mask * make disks sub fields completely immutable * update tests for shielded config and gpu driver * Removed scopes block from product * removed apis required * break shielded_instance_config update msk into submasks * revert update mask for shieldedInstanceConfig * Make vm image immutable * Remove gpu driver config * remove shielded instance config field * removed unspecified values in enums * reupload * removed max_items in serviceAccounts [upstream:c2f6cc6bfdc7c160de0eb36c9b9c9e6f151d8bba] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-c2f6cc6bfdc7c160de0eb36c9b9c9e6f151d8bba
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Support for Workbench instances
Fixes #16336
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9368