Skip to content

Update Cloud Run v2 tests to make service account with sweepable name #16778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

This PR fixes 2 acceptance tests so that:

  • their service accounts are made with unique, sweepable names
  • they don't use binding IAM resources unnecessarily

This will fix a current test failure for TestAccDataSourceGoogleCloudRunV2Job_bindIAMPermission in TPG and TPGB:

Error: Error creating service account: googleapi: Error 409: Service account foo-service-account already exists within project projects/ci-test-project-nightly-beta.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#9620

…hashicorp#9620)

[upstream:0124464a2158773138682030d38e0a454c998238]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 270ad86 into hashicorp:main Dec 12, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
@modular-magician modular-magician deleted the downstream-pr-0124464a2158773138682030d38e0a454c998238 branch November 17, 2024 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant