Fix with18TbScratchDisk test by replacing it with with24TbScratchDisk #16909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hashicorp#9672) Co-authored-by: Timofey Yushchenko <[email protected]> [upstream:e0b5cb9f56acdae5bd7ec59b0d38ca7a648d17ac] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-e0b5cb9f56acdae5bd7ec59b0d38ca7a648d17ac
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16057 . TestAccComputeInstanceTemplate_withScratchDisk was already fixed.
TestAccComputeInstanceTemplate_with18TbScratchDisk is fixed by replacing to 24Tb Local SSDs and different machine type. Also applied the same fix to TestAccComputeInstance_with18TbScratchDisk but it's skipped right now (tested locally).
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9672