Revert "Revert "Fix permadiff that reorders stateful_external_ip blocks on google_compute_instance_group_manager and google_compute_region_instance_group_manager resources""
#16910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks on `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` resources"" (hashicorp#9758) * Revert "Revert "Fix permadiff that reorders `stateful_external_ip` blocks on `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` resources" (hashicorp#9754)" This reverts commit 24ff156. * Sort unexpected IPs not present in TF config, update unit test [upstream:fabeca9e96b1c3d4e9536d78d57e9e8eecdfb92d] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-fabeca9e96b1c3d4e9536d78d57e9e8eecdfb92d
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts GoogleCloudPlatform/magic-modules#9754
I'm re-introducing the original GoogleCloudPlatform/magic-modules#9577 PR but changing the test case that's vulnerable to the reordering problem.
Derived from GoogleCloudPlatform/magic-modules#9758