Skip to content

fixes: permadiff issue if event trigger region is not specified #17328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

As per https://cloud.google.com/functions/docs/reference/rest/v2/projects.locations.functions#eventtrigger, the trigger_region if not provided, defaults to the same region as the function.

fixes #17161

Release Note Template for Downstream PRs (will be copied)

cloudfunctions2: fixed an issue where not specifying `event_config.trigger_region` in `google_cloudfunctions2_function` resulted in a permanent diff. The field now pulls a default value from the API when unset.

Derived from GoogleCloudPlatform/magic-modules#9989

…icorp#9989)

* fixes: permadiff issue if event trigger region is not specified

- fixes hashicorp#17161

* chore: Updated cloudfunction2 test with no explicit trigger_region

[upstream:02e719917fd193513b3e580493a2df4e051cafc9]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 1c78e52 into hashicorp:main Feb 20, 2024
SarahFrench pushed a commit that referenced this pull request Mar 1, 2024
… (#17328)

* fixes: permadiff issue if event trigger region is not specified

- fixes #17161

* chore: Updated cloudfunction2 test with no explicit trigger_region

[upstream:02e719917fd193513b3e580493a2df4e051cafc9]

Signed-off-by: Modular Magician <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
@modular-magician modular-magician deleted the downstream-pr-02e719917fd193513b3e580493a2df4e051cafc9 branch November 17, 2024 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloudfunctions2_function TF changes at every plan
1 participant