Skip to content

Add handwritten sweeper for google_data_loss_prevention_discovery_config #19115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Addresses #19089.

This PR:

  • Adds a new sweeper to remove DiscoveryConfigs in the location passed by the sweeper (us-central1)
  • Creates a sweeper that does not check for unsweepable resources, as there should be only one DiscoveryConfig of each storage type per location per project, so we must delete all DiscoveryConfigs in this location and project to avoid impacting CI tests

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11429

…fig (hashicorp#11429)

[upstream:b3b07233e34229211bda7d28209047af8e108d1e]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit b04c602 into hashicorp:main Aug 13, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant