Skip to content

google_compute_image: Change description field to not be Computed #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2017
Merged

google_compute_image: Change description field to not be Computed #199

merged 1 commit into from
Jul 14, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Jul 14, 2017 •
edited
Loading

Current behavior is wrong. It prevents users from setting the description.

Additionally, I added more assertions in the current acceptance tests.

cc/ @danawillow

@danawillow
Copy link
Contributor 

make testacc TEST=./google TESTARGS='-run=TestAccComputeImage'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeImage -timeout 120m
=== RUN   TestAccComputeImage_resolveImage
--- PASS: TestAccComputeImage_resolveImage (73.10s)
=== RUN   TestAccComputeImage_importFromRawDisk
--- PASS: TestAccComputeImage_importFromRawDisk (57.44s)
=== RUN   TestAccComputeImage_importFromSourceDisk
--- PASS: TestAccComputeImage_importFromSourceDisk (69.80s)
=== RUN   TestAccComputeImage_basic
--- PASS: TestAccComputeImage_basic (67.66s)
=== RUN   TestAccComputeImage_basedondisk
--- PASS: TestAccComputeImage_basedondisk (80.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	348.228s

LGTM, thanks!

@danawillow danawillow merged commit af69c8c into hashicorp:master Jul 14, 2017
@rosbo rosbo changed the title Change description field to not be Computed google_compute_image: Change description field to not be Computed Jul 14, 2017
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@rosbo @danawillow
Change description field to not be Computed (hashicorp#199)
85e8aa3
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @rileykarson
Mark the deleted field computed in google_project_iam_custom_role (ha…
8f83f66 
…shicorp#199)

<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosbo @danawillow