Skip to content

Change Threat Prevention Profile's properties to sets. #21070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

When creating a Security Profile resource the user can specify overrides for their threat prevention profile.
These overrides are of type Array, and so will show diffs between desired state and actual state if the order of the overrides changes.
However, the overrides are supposed to be agnostic to their order, so this PR fixes this by explicitly marking the overrides as Sets.

Fixes #20970

networksecurity: fixed sporadic-diff in `google_network_security_security_profile`

Derived from GoogleCloudPlatform/magic-modules#12814

[upstream:f66cabc0b5c9ba853237f9f387d318b9c35b7638]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner January 28, 2025 16:31
@modular-magician modular-magician merged commit 0a69683 into hashicorp:main Jan 28, 2025
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileOverridesExample
1 participant