Skip to content

storage_bucket: explain what happens when multiple conditions are specified #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 21, 2020

While this is explained in
https://cloud.google.com/storage/docs/lifecycle#configuration, adding it here shouldn't hurt.


@ghost ghost added the size/xs label Feb 21, 2020
@ghost ghost requested review from rileykarson February 21, 2020 19:24
@ghost ghost added the documentation label Feb 21, 2020
@flokli
Copy link
Contributor Author

flokli commented Mar 25, 2020

ping @emilymye

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I lost track of this PR. I have one small comment, otherwise looks good.

@flokli flokli force-pushed the storage_bucket_multiple_conditions branch from 6e5e227 to cf470c3 Compare March 25, 2020 21:47
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to upstream this to the Magic Modules repo and merge it there at the same time as I merge this one.

@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants