Add support for module attribution #7320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add provider meta data to provider * lowercase providerMeta * add providerMeta to generated resources * add module attribution work into data sources * add module attribution for handwritten resources create methods * Add test specifying module_key, remove config declaration from custom deletes * Add check to module key test. Fix container engine versions datasource * Rename module_key to module_name Co-authored-by: Megan Bang <[email protected]> Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
modular-magician
deleted the
downstream-pr-eebd3836e27954bb70c16b958d811fdcba754dff
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoogleCloudPlatform/magic-modules#3992 but rebased
Adds a test as well. VCR tests are failing due to taking significantly longer with the sdkv2, but no meaningful errors in the failing tests.
This should be refactored to not modify the shared config, but rather pass a modified UserAgent if applicable to
sendWithTimeoutIf this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3995