Skip to content

Updated usage of " eq " in instance template filters #8969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Resolved #8936

When the google compute instance template API was first introduced, it allowed filtering based on the eq keyword; however, that has not been a documented keyword for ~3 years, and seems to no longer work. Additionally, the new filters don't support regular expressions.

UPDATE: It looks like I was incorrect about the root cause. Here's an example failure: https://ci-oss.hashicorp.engineering/repository/download/GoogleCloudBeta_ProviderGoogleCloudBetaGoogleProject/183032:id/debug-google-beta-309e845-TestAccInstanceTemplateDatasource_filter.log The failure was not due to all three templates (a, b, c) being available, but rather due to there actually being 3 instances that matched, presumably due to concurrent test runs.

That being said, I still believe we should make this update, since it brings us in line with the currently-documented behavior. Also, by ensuring that the most recent instance template with / without filtering are different, we can make sure that if filtering does break in the future, we will catch it.

Test run demonstrating failures after first commit: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/183267

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#4719

* Changed ordering of instance template creation in mostRecent test

Previously the most recently created instance template was the same whether or not filtering was working; with this change, the most recent template without filtering will be b rather than c

* Updated references to eq filter in tests and docs

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added size/xs labels Apr 21, 2021
@modular-magician modular-magician merged commit c9bdeb6 into hashicorp:master Apr 21, 2021
@ghost
Copy link

ghost commented May 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2021
@modular-magician modular-magician deleted the downstream-pr-38ffd1b324bcf0df7129ab2c767d4bfe873123a1 branch November 17, 2024 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to google_compute_instance_template filtering with "eq"
1 participant