stacks: include existing components when deferring nested stacks #36788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-1/remove-embedded-components
branch
from
ffa57f4 to
4881ea2
Compare
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-2/unknown-stack-instances
branch
from
44c41e1 to
c87fbdb
Compare
liamcervante
commented
Apr 2, 2025
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-1/remove-embedded-components
branch
from
3780e70 to
dd7b3ba
Compare
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-2/unknown-stack-instances
branch
from
c87fbdb to
6f07866
Compare
dsa0x
previously approved these changes
Apr 2, 2025
Base automatically changed from
liamcervante/stacks/removed-chain-1/remove-embedded-components
to
main
April 3, 2025 08:29
liamcervante
force-pushed
the
liamcervante/stacks/removed-chain-2/unknown-stack-instances
branch
from
6f07866 to
6846081
Compare
dsa0x
approved these changes
Apr 3, 2025
liamcervante
deleted the
liamcervante/stacks/removed-chain-2/unknown-stack-instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, components in nested stacks are just ignored during the plan when the nested stack call is deferred.
This PR updates the stacks runtime so a deferred stack call still triggers deferred updates of any components in the nested stack that already exist.