Skip to content

Plan Apply Log #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Plan Apply Log #1487

merged 8 commits into from
Jun 19, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jun 13, 2023

This PR adds the plan and apply log for runs. It also fixes some minor bugs and adds some QoL improvements (see commits).

UX

CleanShot 2023-06-19 at 16 25 35@2x CleanShot 2023-06-19 at 16 25 54@2x CleanShot 2023-06-19 at 16 25 46@2x

@jpogran jpogran self-assigned this Jun 13, 2023
@jpogran jpogran changed the title wip Plan Apply Log Jun 14, 2023
@jpogran jpogran force-pushed the plan_apply_view branch 3 times, most recently from e3f29ed to 7051827 Compare June 15, 2023 15:31
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I added a couple of suggestions and questions.

Do we want to replace the terminal glyphs in the log output to make it more readable?

@dbanck dbanck force-pushed the plan_apply_view branch from 5c92b35 to b96c4f3 Compare June 19, 2023 10:40
@dbanck dbanck marked this pull request as ready for review June 19, 2023 14:05
@dbanck dbanck requested a review from a team as a code owner June 19, 2023 14:05
@dbanck dbanck force-pushed the plan_apply_view branch from 6456930 to 5bd63e8 Compare June 19, 2023 14:08
dbanck added 2 commits June 19, 2023 16:18
The strip-ansi package is only available as ESM
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@dbanck dbanck merged commit 54d5ed5 into f-tfc Jun 19, 2023
@dbanck dbanck deleted the plan_apply_view branch June 19, 2023 14:41
dbanck added a commit that referenced this pull request Jun 19, 2023
* Plan and Apply Log Download Button

This buttons to a run in the Run View that has a plan or an apply to view the raw plan or apply log inside the editor.

* Fix button label typo

* Mark execution-details as nullable

* Improve run list error message

* Add run status to hover

* Round relative year values

* Inline stripAnsi

The strip-ansi package is only available as ESM

* Don't open project filter without login

---------

Co-authored-by: Daniel Banck <[email protected]>
@jpogran jpogran added enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor labels Jun 22, 2023
dbanck added a commit that referenced this pull request Jul 11, 2023
* Plan and Apply Log Download Button

This buttons to a run in the Run View that has a plan or an apply to view the raw plan or apply log inside the editor.

* Fix button label typo

* Mark execution-details as nullable

* Improve run list error message

* Add run status to hover

* Round relative year values

* Inline stripAnsi

The strip-ansi package is only available as ESM

* Don't open project filter without login

---------

Co-authored-by: Daniel Banck <[email protected]>
jpogran added a commit that referenced this pull request Jul 11, 2023
* Plan and Apply Log Download Button

This buttons to a run in the Run View that has a plan or an apply to view the raw plan or apply log inside the editor.

* Fix button label typo

* Mark execution-details as nullable

* Improve run list error message

* Add run status to hover

* Round relative year values

* Inline stripAnsi

The strip-ansi package is only available as ESM

* Don't open project filter without login

---------

Co-authored-by: Daniel Banck <[email protected]>
@jpogran jpogran mentioned this pull request Jul 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants