TFC: Implement run panel for viewing plan #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-tfc-run-panel
branch
from
9a8d236 to
589e88b
Compare
radeksimko
added
enhancement
radeksimko
force-pushed
the
f-tfc-run-panel
branch
5 times, most recently
from
2de7fc6 to
9d51fc0
Compare
1 task
jpogran
reviewed
Oct 23, 2023
radeksimko
force-pushed
the
f-tfc-run-panel
branch
2 times, most recently
from
0e55ed9 to
6c7dadc
Compare
radeksimko
force-pushed
the
f-tfc-run-panel
branch
11 times, most recently
from
08a6864 to
ac777a1
Compare
radeksimko
force-pushed
the
f-tfc-run-panel
branch
from
ac777a1 to
77666a6
Compare
radeksimko
force-pushed
the
f-tfc-run-panel
branch
5 times, most recently
from
07a2105 to
bec481d
Compare
radeksimko
force-pushed
the
f-tfc-run-panel
branch
from
bec481d to
be4e696
Compare
radeksimko
commented
Nov 14, 2023
dbanck
reviewed
Nov 16, 2023
radeksimko
force-pushed
the
f-tfc-run-panel
branch
from
be4e696 to
d040c09
Compare
dbanck
approved these changes
Nov 17, 2023
jpogran
reviewed
Nov 17, 2023
This was referenced Nov 20, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1506
The issue covers both plan and apply, so it's not fully being fixed by this PR yet but we track apply in a follow-up issue #1637
I went as far in the implementation as I felt was reasonable in terms of effort/LOC and value added. Some trade-offs/TODOs are listed below, which I'm happy to file if we agree on those.
The exclusion of testing in particular is a little unfortunate because there's no simple way of telling the user this is a missing feature. They just won't see any tree items and instead see the same welcome view. It's not great but I'm really struggling to come up with a good way around it and I'd greatly appreciate input on this. Also there's so many different test messages with different contexts that it feels like adding support would be quite involved.
Similarly, nesting is a bit more complex than I originally thought, because once we nest under e.g. module, or even just resource type, then we suddenly face situation where we have to either "invent" new icons for the mix of actions (create/update/delete/...) or risk reducing the usefulness of the panel if we don't put any icons there.
UX
Summary: This adds a panel to render the plan log which was previously rendered as raw JSON.
JSON (prior to this PR)
Planned changes
Outputs
Diagnostics
Drifts
Fallback for CLI (non-structured) output
TODO